D5122: This patch fixes bug 374144, Basically it allows users to install via a custom root installation command

[Geetam Chawla]

geetamc created this revision.
geetamc added a project: KDevelop.
Restricted Application added a subscriber: kdevelop-devel.

REVISION SUMMARY
  In makeconfig.ui
  
  - Created a plain text edit and the corresponding config entry in corresponding .kcfg file
  - Added a new entry in combo box that allows users to select custom command
  - If that combobox entry is selected, the config entry is read, checked if it is empty,
    - If it is, the default command kdesudo is selected
    - Otherwise the custom command itself is run.
  
  Reasons to accept this patch:
  -Some distros ship those binaries with wierd names such as kdesu5
  
  Reasons not to accept this patch:
  -You can get random commands to execute by entering it in the plain text edit
  
  Although you can get random commands to execute by entering them in konsole, but that isn't considered
  a security flaw :)
  
  Link <https://bugs.kde.org/show_bug.cgi?id=374144> to bug fixed

TEST PLAN
  I have gotten kdevelop itself to install just fine by custom command "kdesudo".

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D5122

AFFECTED FILES
  projectbuilders/makebuilder/makebuilderconfig.kcfg
  projectbuilders/makebuilder/makeconfig.ui
  projectbuilders/makebuilder/makejob.cpp

To: geetamc
Cc: kdevelop-devel, #kdevelop, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170321/b83f811e/attachment.html>