D5041: Port away from QtWebKit to QtWebEngine

Kevin Funk noreply at phabricator.kde.org
Tue Mar 21 14:47:11 UTC 2017


kfunk accepted this revision.
kfunk added a comment.


  We'll probably need to tweak the CMake code a bit more.
  
  IIUC, right now if neither WK nor WE are installed, CMake will just tell you to get WK. It should give you both options.

INLINE COMMENTS

> CMakeLists.txt:5
> +if(TARGET Qt5::WebEngineWidgets)
> +    set_package_properties(Qt5WebEngineWidgets PROPERTIES
> +        PURPOSE "QtWebKit, for integrated documentation"

FYI: That basically renders `TYPE REQUIRED` redundant. As `Qt5WebEngineWidgets` is already found here.

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D5041

To: apol, #kdevelop, mwolff, kfunk
Cc: kfunk, mwolff, antonanikin, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170321/fc62af6f/attachment-0001.html>


More information about the KDevelop-devel mailing list