D5041: Port away from QtWebKit to QtWebEngine

[Milian Wolff]

mwolff requested changes to this revision.
mwolff added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:5
> +
> +if(PREFER_QTWEBKIT)
> +    find_package(Qt5WebKitWidgets)

I think this should be:

  if (NOT PREFER_QTWEBKIT)
  ... // find webengine
  endif()
  
  if (NOT QT5WEBENGINEWIDGETS_FOUND)
  ... // find webkit
  endif()

or?

> standarddocumentationview.cpp:42
> -
> -    s->setFontFamily(QWebSettings::StandardFont, sansSerifFont.family());
> -    s->setFontFamily(QWebSettings::SerifFont, "Serif");

all of this code here is now lost, don't we need it anymore?

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D5041

To: apol, mwolff, #kdevelop
Cc: mwolff, antonanikin, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170320/b9f5410b/attachment-0001.html>