D3040: Allow scaling documentation view (BUG 285162)

[Milian Wolff]

mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.


  some minor nitpicks. imo feel free to commit after fixing those

INLINE COMMENTS

> CMakeLists.txt:7
>  # plugin versions listed in the .desktop files
> -set(KDEV_PLUGIN_VERSION 26)
>  # Increase this to reset incompatible item-repositories

unrelated change

> standarddocumentationview.cpp:82
> +{
> +    Q_ASSERT(!d->m_zoomController && "Can not initZoom a second time.");
> +

use `Q_ASSERT_X`

> zoomcontroller.cpp:161
> +
> +#include "moc_zoomcontroller.cpp"

this shouldn't be required, or is it?

> zoomcontroller.h:112
> +     */
> +    void factorChanged(double factor);
> +

this should be called `zoomFactorChanged`

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D3040

To: igorkushnir, mwolff, #kdevelop
Cc: rjvbb, mwolff, apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170319/80516346/attachment-0001.html>