D4884: Add ProblemModel::setPlaceHolderText() method

Anton Anikin noreply at phabricator.kde.org
Mon Mar 13 12:10:56 UTC 2017


antonanikin marked an inline comment as done.
antonanikin added inline comments.

INLINE COMMENTS

> mwolff wrote in problemmodel.h:137
> I don't think that this should do many things at once. it should only set the placeholder text, but not clear anything.
> 
> when the model is empty, the placeholder should be shown
> 
> I also don't get why this needs to pass a source and location here? A single placeholder text should be enough?

Fixed

> I also don't get why this needs to pass a source and location here? A single placeholder text should be enough?

This useful for cases when some problem model is used by multiple tools - for example in Valgrind plugin it will be used for providing executed tool name (memcheck/helgrind/DRD).

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D4884

To: antonanikin, mwolff, #kdevelop
Cc: mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170313/664d3c6b/attachment.html>


More information about the KDevelop-devel mailing list