D4910: Initial version of Heaptrack analyzer plugin
Kevin Funk
noreply at phabricator.kde.org
Thu Mar 9 08:52:15 UTC 2017
kfunk accepted this revision.
kfunk added a comment.
LGTM, let's just get this in to master as soon as possible.
Great work! Blog about it!
INLINE COMMENTS
> job.h:40
> + explicit Job(KDevelop::ILaunchConfiguration* launchConfig);
> + explicit Job(int pid);
> + ~Job() override;
`int` -> `long int`
> utils.cpp:30
> +{
> + QString findExecutable(const QString& fallbackExecutableName)
> + {
Sorry, `fallbackExecutablePath` is better
REPOSITORY
R32 KDevelop
REVISION DETAIL
https://phabricator.kde.org/D4910
To: antonanikin, mwolff, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170309/10f2c1cb/attachment.html>
More information about the KDevelop-devel
mailing list