D4910: Initial version of Heaptrack analyzer plugin

Anton Anikin noreply at phabricator.kde.org
Thu Mar 9 02:34:13 UTC 2017


antonanikin marked 11 inline comments as done.
antonanikin added a comment.


  Kevin, thanks for detailed review!

INLINE COMMENTS

> kfunk wrote in debug.h:24
> `KDEV_VERAPP` -> `KDEV_HEAPTACK`

Ooops :)

> kfunk wrote in job.cpp:155
> This whole casing on `e` is already handled by `OutputExecuteJob::childProcessError` already, no? No need to duplicate code.

Ok, you are right - we no need some special error processing code here.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D4910

To: antonanikin, mwolff, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170309/cade90c5/attachment-0001.html>


More information about the KDevelop-devel mailing list