D4883: Add KDevelop::PluginProblem class

[Kevin Funk]

kfunk requested changes to this revision.
kfunk added a comment.
This revision now requires changes to proceed.


  Sorry Anton, more nitpicks/questions :)

INLINE COMMENTS

> problem.cpp:213
> +{
> +    Q_UNUSED(source);
> +}

Issue a runtime warning maybe? => `qCWarning(...)`

> problem.h:120
> +public:
> +    explicit PluginProblem(const QString& pluginName);
> +    ~PluginProblem() override;

I'm wondering if we should just merge `PluginProblem` with `DetectedProblem`...

Just add `DetectedProblem::DetectedProblem(const QString& pluginName)` and set `source = Plugin` in that case).

`DetectedProblem::sourceString` then returns the custom plugin name if `source == Plugin`.

`PluginProblem` does not really add much to `DetectedProblem` this looks like unnecessary code bloat. Other opinions?

> test_pluginproblem.cpp:40
> +{
> +    AutoTestShell::init();
> +    TestCore::initialize(Core::NoUi);

`init({{}})` (no joke) -- so we don't load any plugins :)

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D4883

To: antonanikin, mwolff, #kdevelop, kfunk
Cc: kfunk, mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170307/6ac1b1ca/attachment.html>