D3040: Allow scaling documentation view (BUG 285162)

[Milian Wolff]

mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.


  lgtm in principle, but there are two checks that imo need to be removed to cleanup the code. it's not a good idea to be overly pedantic in code, rather use assertions like we do elsewhere

INLINE COMMENTS

> zoomcontroller.cpp:108
> +{
> +    if (Q_UNLIKELY(!event)) {
> +        qCWarning(UTIL) << "ZoomController::handleKeyPressEvent: null event.";

this doesn't actually happen, right? Imo you can simply replace this with a `Q_ASSERT`, or remove it altogether

> zoomcontroller.cpp:136
> +{
> +    if (Q_UNLIKELY(!event)) {
> +        qCWarning(UTIL) << "ZoomController::handleWheelEvent: null event.";

dito above

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D3040

To: igorkushnir, #kdevelop, mwolff
Cc: rjvbb, mwolff, apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170305/ee5e03ac/attachment.html>