D4884: Add ProblemModel::setPlaceHolderText() method

[Milian Wolff]

mwolff requested changes to this revision.
mwolff added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> problemmodel.h:137
> +    /**
> +     * Clear current problems and add new "placeholder" item (problem).
> +     *

I don't think that this should do many things at once. it should only set the placeholder text, but not clear anything.

when the model is empty, the placeholder should be shown

I also don't get why this needs to pass a source and location here? A single placeholder text should be enough?

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D4884

To: antonanikin, #kdevelop, mwolff
Cc: mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170305/827f9c2b/attachment.html>