D4936: Restore compile-time support for Python 3.4.3+

Sven Brauch noreply at phabricator.kde.org
Sat Mar 4 20:03:11 UTC 2017


brauch accepted this revision.
brauch added a comment.
This revision is now accepted and ready to land.


  Nice work, looks good to me -- didn't test with 3.4 though. Thank you very much!

INLINE COMMENTS

> pyduchaintest.cpp:997
>      QTest::newRow("dict_kwarg_type") << "def foo(**kwargs): return kwargs['']\ncheckme = foo(**{'a': 12})" << "int";
> +#if PYTHON_VERSION_MINOR >= 5
>      QTest::newRow("dict_norm_kwarg_type") << "def foo(**kwargs): return kwargs['']\n"

Can we use QT_VERSION_CHECK or so such that this doesn't break for Python 4? ;)

REPOSITORY
  R53 KDevelop: Python Support

REVISION DETAIL
  https://phabricator.kde.org/D4936

To: flherne, brauch
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170304/16ea572d/attachment.html>


More information about the KDevelop-devel mailing list