[Differential] [Commented On] D4776: support for $this as an array when implementing ArrayAccess

[Alexander Zhigalin]

zhigalin added inline comments.

INLINE COMMENTS

> declarationbuilder.cpp:972
> +                    QString funcname = func.last().identifier().str();
> +                    if(funcname == "offsetexists" || funcname == "offsetget" || funcname == "offsetset" || funcname == offsetunset")
> +                        noOfFunc++;

You should sleep more I think

> declarationbuilder.cpp:973
> +                    if(funcname == "offsetexists" || funcname == "offsetget" || funcname == "offsetset" || funcname == offsetunset")
> +                        noOfFunc++;
> +                }

style issue: braces are needed even for one-line statements

REPOSITORY
  R52 KDevelop: PHP Support

REVISION DETAIL
  https://phabricator.kde.org/D4776

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: shashwatdixit, #kdevelop, mwolff, zhigalin, kfunk
Cc: kdevelop-devel, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170301/40995ee9/attachment.html>