D6436: Fix crash on clicking "Show documentation for xyz" in code tooltip

[Milian Wolff]

mwolff added a comment.


  could you move the register metatype please?

INLINE COMMENTS

> abstractnavigationcontext.cpp:218
> +        // which can happen e.g. due to focus change events resulting in tooltip destruction and thus this object
> +        qRegisterMetaType<IDocumentation::Ptr>("IDocumentation::Ptr");
> +        QMetaObject::invokeMethod(ICore::self()->documentationController(), "showDocumentation", Qt::QueuedConnection, Q_ARG(IDocumentation::Ptr, doc));

this should be done in a central place, once. or at least not every time the action is invoked - so maybe put it into a ctor

we should really clean that up and introduce a central method for the individual libs to register their metatypes...

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D6436

To: kossebau, #kdevelop, apol
Cc: mwolff, apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170630/2e04540c/attachment.html>