D6417: Avoid duplicates in virtual overrides code completion proposals

[Milian Wolff]

mwolff added inline comments.

INLINE COMMENTS

> test_codecompletion.cpp:564
> +        << "class Foo { virtual int foo(int i); virtual int overridden(int i); };\n"
> +           "class Baz : Foo { int foo(int i) overridden; };\n"
> +           "class Bar : Baz \n{int overridden(int i) overridden;\n}"

this should be `override`, no?

> test_codecompletion.cpp:565
> +           "class Baz : Foo { int foo(int i) overridden; };\n"
> +           "class Bar : Baz \n{int overridden(int i) overridden;\n}"
> +        << CompletionItems{{4, 1}, {"foo(int i)"}};

second should be `override`

> test_codecompletion.cpp:575
> +        << "class Foo { virtual void foo() = 0; virtual void overridden() = 0; };\n"
> +           "class Baz : Foo { void foo() overridden; };\n"
> +           "class Bar : Baz \n{void overridden() overridden;\n}"

dito

> test_codecompletion.cpp:576
> +           "class Baz : Foo { void foo() overridden; };\n"
> +           "class Bar : Baz \n{void overridden() overridden;\n}"
> +        << CompletionItems{{4, 1}, {"foo()"}};

dito

REPOSITORY
  R32 KDevelop

BRANCH
  noduplicatesincodecompletion

REVISION DETAIL
  https://phabricator.kde.org/D6417

To: kossebau, #kdevelop, mwolff
Cc: mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170628/b42f3071/attachment-0001.html>