D6412: Refactor and fix DU-Chain creation

Sven Brauch noreply at phabricator.kde.org
Tue Jun 27 20:57:38 UTC 2017


brauch accepted this revision.
brauch added a comment.
This revision is now accepted and ready to land.


  Seems sensible to me from a first look, certainly more than it was before ;)

INLINE COMMENTS

> functionitem.cpp:48
> +    {
> +        DUChainReadLocker lock;
> +        for(auto import : function->internalContext()->importedParentContexts())

use DUChainUtils::getArgumentContext

> testduchain.cpp:685
>          return 0;
> -    AbstractFunctionDeclaration* function = dynamic_cast<AbstractFunctionDeclaration*>(decls.first());
> +    go::GoFunctionDeclaration* function = dynamic_cast<go::GoFunctionDeclaration*>(decls.first());
>      if(!function)

you can use auto

REPOSITORY
  R59 KDevelop Go

BRANCH
  fixing

REVISION DETAIL
  https://phabricator.kde.org/D6412

To: ematirov, brauch, apol
Cc: kdevelop-devel, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170627/c028e0b6/attachment-0001.html>


More information about the KDevelop-devel mailing list