D6398: Fix highlighting when editing in patch review

[Christoph Roick]

croick created this revision.
Restricted Application added a subscriber: kdevelop-devel.

REVISION SUMMARY
  Problems:
  
  - removing markers in foreach loop lead to crash (BUG 380125)
  - highlighting when editing in patch review was broken
  - reloading would stop the highlighting
  
  Fixes:
  
  - textInserted/textRemoved signals only send line-by-line (or character-by-character) changes and there are extra signals for newline insertion/removal. The patch reflects this mechanism.
  - Redo the highlighting when the document is reloaded.
  - Remove one of the duplicated lists of ranges (mainly to improve maintainability).
  
  Persisting Issue:
  
  - possible dangling mark when removing the "wrong" newline from a set of newline-only-lines changes.
  
  BUG: 380125

TEST PLAN
  - tested text insertion, text removal and mark clicking and the combination of those with (mostly) consistent results for a git diff

REPOSITORY
  R33 KDevPlatform

BRANCH
  patchhighlight

REVISION DETAIL
  https://phabricator.kde.org/D6398

AFFECTED FILES
  plugins/patchreview/patchhighlighter.cpp
  plugins/patchreview/patchhighlighter.h

To: croick, #kdevelop
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170626/accbc2a7/attachment.html>