D6286: Fix crash when trying to kill a finished NativeAppJob

Christoph Roick noreply at phabricator.kde.org
Mon Jun 19 21:27:43 UTC 2017


croick created this revision.
Restricted Application added a subscriber: kdevelop-devel.

REVISION SUMMARY
  - when starting the same job twice, a dialog pops up, asking whether to kill the running job
  - if the job finished meanwhile, the running job instance ceases to exist and accessing its member causes a crash
  - probably the same as Bug 364317
  
  Solution:
  
  - add a check for existence of the job after the dialog
  
  BUG: 364317

TEST PLAN
  - start the same job twice (a unit test for instance)
  - click on "Yes" (do kill the running job), if the dialog pops up, after the job finished

REPOSITORY
  R33 KDevPlatform

BRANCH
  dev-local

REVISION DETAIL
  https://phabricator.kde.org/D6286

AFFECTED FILES
  plugins/execute/nativeappjob.cpp

To: croick, #kdevelop
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170619/c67fa50f/attachment.html>


More information about the KDevelop-devel mailing list