D6262: Implement persisting search history for Find in Files

Christoph Roick noreply at phabricator.kde.org
Sun Jun 18 23:13:03 UTC 2017

croick marked 2 inline comments as done.
croick added inline comments.


> grepdialog.cpp:113-149
> +///Returns the chosen directories or files (only the top directories, not subfiles)
> +QList<QUrl> getDirectoryChoice(const QString& text)
> +{
> +    QList<QUrl> ret;
> +    if (text == allOpenFilesString()) {
> +        foreach(IDocument* doc, ICore::self()->documentController()->openDocuments())
> +            ret << doc->url();

I made these static from the former directoryChanged and getDirectoryChoice member functions

> grepdialog.cpp:415
> +    // only proceed if all projects have been opened
> +    if (KDevelop::ICore::self()->activeSession()->config()->group("General Options").readEntry("Open Projects", QList<QUrl>()).count() !=
> +        KDevelop::ICore::self()->projectController()->projects().count())

I wonder if there is a better way to get the number of staged projects.

  R33 KDevPlatform


To: croick, #kdevelop
Cc: apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170618/3679c834/attachment-0001.html>

More information about the KDevelop-devel mailing list