D6262: Implement persisting search history for Find in Files

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> grepviewplugin.cpp:109
>  {
> -    if (m_currentDialog) {
> -        m_currentDialog->reject();
> -        m_currentDialog->deleteLater();
> +    foreach (QPointer<GrepDialog> p, m_currentDialogs) {
> +        if (p) {

const &

> grepviewplugin.cpp:180
>          dlg->setSettings(dlgSettings);
> -    }
> -    else if(!setLastUsed)
> -    {
> +    } else if (!setLastUsed) {
>          QString pattern = patternFromSelection(doc);

Please remove style changes, they make it much harder to review your patches.

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D6262

To: croick, #kdevelop
Cc: apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170618/5a12f95a/attachment.html>