D6228: Remove blocked feature of extra menus for project items' parent folders
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Thu Jun 15 15:30:46 UTC 2017
kossebau created this revision.
Restricted Application added a subscriber: kdevelop-devel.
REVISION SUMMARY
Feature has been accidentally disabled in 2013 due to porting mistake
with inverted logic in commit https://phabricator.kde.org/R33:0e00aa2a85254e90ec945c8c35b6aed3389edab8:
"!parent->url().isEmpty()" became wrongly "!parent->path().isValid()"
Seems no-one missed the featzure since. Besides, the UX is questionable
custom with the separate new menus popping up instead of being in submenus.
So removing as dead code for now.
REPOSITORY
R33 KDevPlatform
BRANCH
removeMenusForParentPathItems
REVISION DETAIL
https://phabricator.kde.org/D6228
AFFECTED FILES
plugins/projectmanagerview/projecttreeview.cpp
project/projectutils.cpp
project/projectutils.h
shell/textdocument.cpp
To: kossebau, #kdevelop
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170615/af264130/attachment.html>
More information about the KDevelop-devel
mailing list