D6218: Fix runes parsing.

Mikhail Ivchenko noreply at phabricator.kde.org
Wed Jun 14 12:21:41 UTC 2017


ematirov added inline comments.

INLINE COMMENTS

> apol wrote in parsertest.cpp:129
> Maybe as part of another iteration, but this should better be: `QCOMPARE( lexer.read().kind, TokenTypeWrapper::Token_RUNE);`

Good idea. I will fix that in another RR since there are a lot of such QVERIFY misuses in that file (not related to this test\change)

REPOSITORY
  R59 KDevelop Go

BRANCH
  fix_runes

REVISION DETAIL
  https://phabricator.kde.org/D6218

To: ematirov, apol, brauch
Cc: kdevelop-devel, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170614/a82346df/attachment.html>


More information about the KDevelop-devel mailing list