D6218: Fix runes parsing.

Aleix Pol Gonzalez noreply at phabricator.kde.org
Tue Jun 13 23:01:27 UTC 2017


apol added inline comments.

INLINE COMMENTS

> parsertest.cpp:125
>  {
>      //@TODO stuff like ''' shouldn't actually be accepted, try fixing rune lexer rule in go.g
> +    QByteArray code = "'\\'   '\"'   '~'   '_'  '0'  'a'  '\\''   'щ'  '''  ";

Shouldn't the TODO be fixed then?

> parsertest.cpp:129
>      Lexer lexer(iter);
>      QVERIFY( lexer.read().kind == TokenTypeWrapper::Token_RUNE);
>      QVERIFY( lexer.read().kind == TokenTypeWrapper::Token_RUNE);

Maybe as part of another iteration, but this should better be: `QCOMPARE( lexer.read().kind, TokenTypeWrapper::Token_RUNE);`

REPOSITORY
  R59 KDevelop Go

BRANCH
  fix_runes

REVISION DETAIL
  https://phabricator.kde.org/D6218

To: ematirov, apol, brauch
Cc: kdevelop-devel, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170613/95bd346c/attachment.html>


More information about the KDevelop-devel mailing list