D6068: Only show cppcheck stuff in the editor contect menu if on a C/C++ file

[Kevin Funk]

kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.


  LGTM, should go to 5.1 branch

INLINE COMMENTS

> plugin.cpp:228
> +    if (context->hasType(KDevelop::Context::EditorContext) && m_currentProject && !isRunning()) {
> +        auto eContext = dynamic_cast<KDevelop::EditorContext*>(context);
> +        QMimeDatabase db;

Style: Rename to `editorContext`

> plugin.cpp:230
> +        QMimeDatabase db;
> +        const auto mime = db.mimeTypeForUrl(eContext->url());
>  

Style: Rename to `mimeType`

REPOSITORY
  R32 KDevelop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6068

To: apol, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170602/e6fbf688/attachment.html>