D6966: Turn SourceFormatterController::formatFiles into a job

Aleix Pol Gonzalez noreply at phabricator.kde.org
Fri Jul 28 15:39:12 UTC 2017

apol requested changes to this revision.
apol added a comment.
This revision now requires changes to proceed.

  Maybe it would make sense to use `ExecuteCompositeJob` and make every separate file a subjob.
  It would help to simplify the async code.


> sourceformatterjob.cpp:138
> +    auto getJob = KIO::storedGet(url);
> +    if (getJob->exec()) {
> +        // TODO: really fromLocal8Bit/toLocal8Bit? no encoding detection? added in b8062f736a2bf2eec098af531a7fda6ebcdc7cde

Use `->start()`

> sourceformatterjob.cpp:145
> +        auto putJob = KIO::storedPut(text.toLocal8Bit(), url, -1, KIO::Overwrite);
> +        if (!putJob->exec())
> +            // TODO: integrate with job error reporting, use showErrorMessage?

should be `->start()` and then integrate by using `setError` and `setErrorString`.

  R33 KDevPlatform


To: kossebau, #kdevelop, apol
Cc: apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170728/c8ae41f6/attachment-0001.html>

More information about the KDevelop-devel mailing list