D6905: clang: fix precompiled preamble cache misses

Sven Brauch noreply at phabricator.kde.org
Wed Jul 26 22:03:41 UTC 2017

brauch marked 2 inline comments as done.
brauch added a comment.

  Thanks for the reviews, I'll submit a fixed version tomorrow. I would not backport this tbh, but instead release 5.2 as soon as possible; I feel like the implications are relatively far-reaching and that shouldn't be in a point release. People who want to try the fix can use our 5.2 AppImage (with up-to-date clang).


> mwolff wrote in parsesession.cpp:186
> any idea why we added this in the first place? can you also add something to your commit message saying why you remove this now? it seems somewhat unrelated to the rest (?)

It was supposed to tackle a similar problem but is now deprecated, according to documentation. I assume it does nothing right now anyways, so I removed it while touching that code.

> mwolff wrote in parsesession.cpp:198
> yeah, better add the ifdef?

Yes, I'll ifdef that

  R32 KDevelop


To: brauch, kfunk, mwolff, kdevelop-devel
Cc: geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170726/b67fb7d7/attachment.html>

More information about the KDevelop-devel mailing list