D6807: Fix segmentation fault caused by certain files

Kevin Funk noreply at phabricator.kde.org
Fri Jul 21 18:30:42 UTC 2017

kfunk added a comment.

  In https://phabricator.kde.org/D6807#127188, @zhigalin wrote:
  > In https://phabricator.kde.org/D6807#127164, @apol wrote:
  > > Maybe you could add a unit test?
  > What I should test?
  1. revert your patch
  2. add a test case parsing your test case from https://bugs.kde.org/show_bug.cgi?id=381123#c2 -- make sure running the test case inhibits a crash
  3. reduce the test case as much as possible
  3.1) bonus points for actually figuring out why `internalContext` is nullptr
  4. reapply your patch, make sure running the test no longer crashes

  R52 KDevelop: PHP Support


To: zhigalin
Cc: kfunk, apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170721/15cde46a/attachment.html>

More information about the KDevelop-devel mailing list