D6593: Remove messages of already running CTests for UnitTests
noreply at phabricator.kde.org
Mon Jul 10 20:37:30 UTC 2017
croick marked an inline comment as done.
croick added a comment.
In https://phabricator.kde.org/D6593#123646, @apol wrote:
> Other than that, LGTM. I'm not sure why you need to go through the job list again, but it's not a big penalty so if that's what makes it stable, let's go for it.
I experienced a crash in operator==() of job->m_cfgname == m_cfgname. Theoretically, the same job could be started three times (which was not unusual while all tests were still called "CTest"), so it was possible to kill all jobs in the third instance, while the second is not handled at first. When the second finally accessed job->m_cfgname for a job that is deleted already, the program crashed.
To: croick, #kdevelop
Cc: apol, kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel