D6594: Correctly access OutputWidget/StandardOutputView::setTitle()

Christoph Roick noreply at phabricator.kde.org
Mon Jul 10 20:10:14 UTC 2017


croick marked an inline comment as done.
croick added inline comments.

INLINE COMMENTS

> kfunk wrote in outputwidget.cpp:678
> Is this check really necessary?
> 
> `data->outputdata` isn't accessed further in this function.

No, it's not. Thanks. I just copied from removeOutput() which implicitly needs the check.

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D6594

To: croick, #kdevelop
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170710/c3e855a5/attachment.html>


More information about the KDevelop-devel mailing list