D6594: Correctly access OutputWidget/StandardOutputView::setTitle()
Kevin Funk
noreply at phabricator.kde.org
Sun Jul 9 23:27:58 UTC 2017
kfunk added inline comments.
INLINE COMMENTS
> outputwidget.cpp:678
> {
> - if( data->type & KDevelop::IOutputView::MultipleView ) {
> - m_tabwidget->setTabText(outputId - 1, title);
> + if(data->outputdata.contains(outputId)) {
> + QTreeView* view = m_views.value(outputId, nullptr);
Is this check really necessary?
`data->outputdata` isn't accessed further in this function.
REPOSITORY
R33 KDevPlatform
REVISION DETAIL
https://phabricator.kde.org/D6594
To: croick, #kdevelop
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170709/0fe473da/attachment-0001.html>
More information about the KDevelop-devel
mailing list