D6542: Fixes to GrepOutputView toolbar

Christoph Roick noreply at phabricator.kde.org
Fri Jul 7 19:11:54 UTC 2017

croick marked an inline comment as done.
croick added inline comments.


> kfunk wrote in grepdialog.cpp:426
> This doesn't really change behavior,does it?

QTimer emits with a QPrivateSignal which conflicts with the bool argument

> kfunk wrote in grepdialog.h:56
> `nextHistory(false)` is never called(?)

it is called as a slot by grepJobFinished, which now returns whether the job was successfully finished

> kfunk wrote in grepoutputview.cpp:357
> Turn that into a `updateButtonStates()` and do something along
>   const bool enabled = model()->hasResults();
>   m_prev->setEnabled(enabled);
>   ...
> Then call it from `GrepOutputView::expandElements` and other places?

self checking does not work here with the asynchronous job, so enabling/disabling is done explicitly

  R33 KDevPlatform


To: croick, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170707/a90531f0/attachment.html>

More information about the KDevelop-devel mailing list