D6542: Fixes to GrepOutputView toolbar

[Christoph Roick]

croick created this revision.
Restricted Application added a subscriber: kdevelop-devel.

REVISION SUMMARY
  Fixes to GrepOutputView toolbar
  
  - fix crash when aborting grep jobs at startup by clicking on "Clear Search History" (introduced in commit https://phabricator.kde.org/R33:42eb6bb62c28923e5f6f4ff0cee3e8e6ee07bd2e)
  - correctly disable result navigation buttons (fixes crash when clicking on "Collapse All" button for an empty result)
  - change icons for "Collapse All" and "Expand All" (were marked as TODO)
  
  Before:
  F3805931: old.png <https://phabricator.kde.org/F3805931>
  
  After:
  F3805930: new.png <https://phabricator.kde.org/F3805930>

TEST PLAN
  - quit KDevelop with a long GrepJob in history
  - restart KDevelop and abort job by clicking on "Clear Search History" -> no crash
  
  - start a long GrepJob and stop it by clicking on "Clear Search History"
  - navigation buttons are now disabled

REPOSITORY
  R33 KDevPlatform

BRANCH
  grep

REVISION DETAIL
  https://phabricator.kde.org/D6542

AFFECTED FILES
  plugins/grepview/grepdialog.cpp
  plugins/grepview/grepdialog.h
  plugins/grepview/grepoutputview.cpp
  plugins/grepview/grepoutputview.h
  plugins/grepview/grepviewplugin.cpp
  plugins/grepview/grepviewplugin.h

To: croick, #kdevelop
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170707/592c61cd/attachment-0001.html>