D6179: Reenable icon border menu

[Kevin Funk]

kfunk added a comment.


  Just tested this, I like it. Just a couple of minor issues then this is good to go.

INLINE COMMENTS

> breakpointmodel.cpp:148
>      QMenu menu;
> -    QAction deleteAction(QIcon::fromTheme(QStringLiteral("edit-delete")), i18n("&Delete Breakpoint"), nullptr);
> -    QAction disableAction(QIcon::fromTheme(QStringLiteral("dialog-cancel")), i18n("&Disable Breakpoint"), nullptr);
> -    QAction enableAction(QIcon::fromTheme(QStringLiteral("dialog-ok-apply")), i18n("&Enable Breakpoint"), nullptr);
> -    menu.addAction(&deleteAction);
> -    if (b->enabled()) {
> -        menu.addAction(&disableAction);
> -    } else {
> -        menu.addAction(&enableAction);
> +    QAction* breakpointA = menu.addAction(QIcon::fromTheme(QStringLiteral("breakpoint")), i18n("&Breakpoint"));
> +    breakpointA->setCheckable(true);

Please rename `breakpointA` -> `breakpointAction`

> breakpointmodel.cpp:162
> +
>      QAction *a = menu.exec(pos);
> +    if (a) {

`a` -> `triggeredAction`

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D6179

To: croick, #kdevelop
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170706/ffc6dcc0/attachment-0001.html>