D6505: Fix external launch of executables with spaces in paths[windows]
Geetam Chawla
noreply at phabricator.kde.org
Tue Jul 4 15:11:02 UTC 2017
geetamc created this revision.
Restricted Application added a subscriber: kdevelop-devel.
REVISION SUMMARY
Instead of first splitting the arguments, and replacing %exe and %workdir by their quoted values,
the values are replaced first and split later which strips the command of \^" at beginning and end.
TEST PLAN
Executing in external terminal works fine after the patch:
-when executable path contains spaces (on both windows and linux.)
-when it does not contain any spaces.
before:
F3803895: before.png <https://phabricator.kde.org/F3803895>
after:
F3803896: after.png <https://phabricator.kde.org/F3803896>
REPOSITORY
R33 KDevPlatform
REVISION DETAIL
https://phabricator.kde.org/D6505
AFFECTED FILES
plugins/execute/nativeappjob.cpp
To: geetamc, #kdevelop
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170704/f3cb0e6f/attachment.html>
More information about the KDevelop-devel
mailing list