[Differential] [Requested Changes To] D4250: Add :vsplit and :split support in kdevelop

[Milian Wolff]

mwolff requested changes to this revision.
mwolff added a reviewer: mwolff.
mwolff added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> ktexteditorpluginintegration.cpp:355
> +{
> +    m_mainWindow->d->split(orientation);
> +}

use public API, i.e. add a void split(Qt::Orientation orientation); to MainWindow and call d->split internally. so here it's just

  m_mainWindow->split(orientation);

> mainwindow.h:51
>      friend class UiController;
> +    friend class KTextEditorIntegration::MainWindow;
>      Q_OBJECT

this should be removed, instead add a

  void split(Qt::Orientation orientation);

below and implement it as

  void MainWindow::split(Qt::Orientation orientation)
  {
      d->split(orientation);
  }

REVISION DETAIL
  https://phabricator.kde.org/D4250

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: head7, brauch, mwolff
Cc: mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170130/c9711d5c/attachment.html>