[Differential] [Updated] D4334: Pressing "Continue" starts "Debug" if program is not running
noreply at phabricator.kde.org
Mon Jan 30 18:29:38 UTC 2017
dporobic marked 2 inline comments as done.
dporobic added a comment.
In https://phabricator.kde.org/D4334#81123, @mwolff wrote:
> I am missing some things here, besides the nitpicks below:
> The action's tooltip, and possibly even its icon, should now imo update depending on the state to indicate what action will be triggered when it is executed.
> Can you implement that as well please?
I've implemented some functionality to fix this, can you please have a look if this is ok or if I should take a different approach.
> mwolff wrote in debugcontroller.cpp:482
> if the dialog gets canceled, we may still not have a launch, right? will that still work fine (i.e. no crash/warning), or should that be catched explicitly here?
A crash should not happen, further execution will be stopped here and a warning will be written to console. It's the same why how the real debug action is implemented.
void KDevelop::RunController::executeDefaultLaunch(const QString& runMode)
auto dl = defaultLaunch();
if( !dl )
qWarning() << "no default launch!";
execute( runMode, dl );
> mwolff wrote in kdevdebuggershellui.rc:36
> couldn't you simply remove the debug_continue altogether from both states, since if you never disable it, you also never have to reenable it again?
I am setting it to disabled, during the "active" state and it looks more clear when all action are there. But I can remove them if you think that this is useless.
To: dporobic, apol, kfunk, mwolff
Cc: mwolff, kdevelop-devel, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel