[Differential] [Accepted] D4232: Bring back memory view

[Milian Wolff]

mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.


  lgtm now, thanks a lot!

INLINE COMMENTS

> memviewdlg.cpp:475
>  {
> -    MemoryView* widget = new MemoryView(this);
> -    toolBox_->addItem(widget, widget->windowTitle());
> -    toolBox_->setCurrentIndex(toolBox_->indexOf(widget));
> -    memoryViews_.push_back(widget);
> +    MemoryView* widget = new MemoryView(static_cast<QWidget*>(this));
> +    m_toolBox->addItem(widget, widget->windowTitle());

is this cast really required? I don't see why

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D4232

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: volden, #kdevelop, mwolff
Cc: mwolff, kossebau, kdevelop-devel, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170130/4f84e771/attachment.html>