[Differential] [Accepted] D4330: Feature: on DnD of repo urls on window show Open Project dialog for url

[Milian Wolff]

mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.


  minor nitpick, feel free to fix that and push directly then

INLINE COMMENTS

> ibasicversioncontrol.h:84
>      /**
> +     * Is the given @p remoteLocation a valid url to try to fetch from?
> +     * This checks whether the @p remoteLocation is a proper url for a remote versioning system or not.

Checks whether the given @p remoteLocation is a valid remote repository URL.
<empty line>
...

> ibasicversioncontrol.h:94
> +    virtual bool isValidRemoteRepositoryUrl(const QUrl& remoteLocation);
> +    // TODO: default impl just temporary to ease life for external plugins, for 5.2 turn to: = 0;
> +

what external plugins exist? make this = 0; from the start please

REPOSITORY
  R33 KDevPlatform

BRANCH
  supportDnDOfRepoUrls

REVISION DETAIL
  https://phabricator.kde.org/D4330

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #kdevelop, mwolff
Cc: mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170130/5c8be416/attachment.html>