[Differential] [Updated] D4095: Refactor to embrace a cmake server import backend
Aleix Pol Gonzalez
noreply at phabricator.kde.org
Mon Jan 30 01:39:00 UTC 2017
apol marked 4 inline comments as done.
apol added inline comments.
> mwolff wrote in cmakeserver.cpp:64
> what if the first connect fails - we simply get an error and disconnect and don't try thereafter, right? couldn't we retry for up to N times (say every 100ms for up to 1s?) to make this a bit less brittle?
FWIW, this is the code in QtCreator:
connect(&m_connectionTimer, &QTimer::timeout, this, &ServerMode::connectToServer);
I'd prefer doing the same as them and discussing with Tobias how to improve it, as he did cmake-server implementation as well as qtcreator.
To: apol, kfunk, mwolff, #kdevelop
Cc: mwolff, antonanikin, arrowdodger, kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel