[Differential] [Requested Changes To] D4325: Make output filtering more robust to app invalid columns

[Milian Wolff]

mwolff requested changes to this revision.
mwolff added a reviewer: mwolff.
mwolff added a comment.
This revision now requires changes to proceed.


  minor style nitpick, otherwise lgtm - thanks!

INLINE COMMENTS

> outputformats.cpp:52
>  {
> -    return columnGroup >= 0 ? match.captured( columnGroup ).toInt() - 1 : 0;
> +    if(columnGroup < 0) return 0;
> +    int columnNumberFromApp = match.captured( columnGroup ).toInt() - 1;

style: spaces after if, always use braces

overall, I'd rewrite this as:

  return columnGroup < 0 ? 0 : std::max(match.captured(columnGroup).toInt() - 1, 0);

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D4325

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: volden, kdevelop-devel, mwolff
Cc: mwolff
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170129/70289616/attachment-0001.html>