[Differential] [Commented On] D2958: Add functionality for hiding unlocked docks during editor focusing

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> idealcontroller.h:73
>      void showBottomDock(bool show);
> -    void toggleDocksShown();
> +    void toggleDocksShown(bool hideUnlocked = false);
>  

When do we ever hide the locked?
If a toolview is locked, it should never be hidden. Maybe removed, but not hidden.

> antonanikin wrote in mainwindow_p.cpp:280
> Done. Thanks for your idea about "right place" for the new code.

No, I'm not sure what's going on, but still we are talking different things.

- `::focusEditor` is for when you want to Focus the Editor. But it's not supposed to touch the toolviews.
- `::toggleDocksShown` should respect the Docks to be Shown, additionally to focus the editor when we are hiding the docks.

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D2958

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antonanikin, #kdevelop
Cc: apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170127/c54a7bfc/attachment.html>