Review Request 129884: Fix for bug 360539
Francis Herne
mail at flherne.uk
Thu Jan 26 10:52:39 UTC 2017
> On Jan. 26, 2017, 9:58 a.m., Tomaz Canabrava wrote:
> > sublime/idealdockwidget.cpp, line 89
> > <https://git.reviewboard.kde.org/r/129884/diff/1/?file=490167#file490167line89>
> >
> > Lots of spaces not removed on the code after you saved your files.
>
> Damir Porobic wrote:
> Was not aware that I need to avoid them. Will keep an eye on it in future.
KDevelop has settings for this: `Editor -> Open/Save -> Remove trailing spaces` and `Editor -> Appearance -> Highlight trailing spaces`.
Most projects now use Phabricator instead of ReviewBoard, whichever page you read should be updated.
- Francis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129884/#review102247
-----------------------------------------------------------
On Jan. 25, 2017, 7:28 p.m., Damir Porobic wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129884/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2017, 7:28 p.m.)
>
>
> Review request for KDevelop.
>
>
> Bugs: 360539
> http://bugs.kde.org/show_bug.cgi?id=360539
>
>
> Repository: kdevplatform
>
>
> Description
> -------
>
> Fix for bug 360539. Saving visibility status of view toolbars
>
>
> Diffs
> -----
>
> sublime/idealdockwidget.h c966481
> sublime/idealdockwidget.cpp c79b1ba
>
> Diff: https://git.reviewboard.kde.org/r/129884/diff/
>
>
> Testing
> -------
>
> Tested if toolbars are correctly hidden and shown again after closing and opening up kdevelop.
> Checked config kdeveloprc to confirm that variables are written corretly
>
>
> Thanks,
>
> Damir Porobic
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170126/048803d4/attachment-0001.html>
More information about the KDevelop-devel
mailing list