[Differential] [Request, 8 lines] D4274: Remove BaseType typedef from Type classes

Nicolás Alvarez noreply at phabricator.kde.org
Wed Jan 25 01:07:00 UTC 2017


nalvarez created this revision.
nalvarez set the repository for this revision to R33 KDevPlatform.
Restricted Application added a subscriber: kdevelop-devel.

REVISION SUMMARY
  The documentation on `AbstractType` says subclasses must have a `BaseType` typedef. However, very few types actually had it, and nothing uses it anymore (apparently only the oldcpp code used it in the past).
  
  So I'm removing the remaining `BaseType` typedefs, and adjusting the doxygen comment that says you need it.
  
  If approved, I'll send patches for other repos too (kdevelop has 1 remaining BaseType and kdev-python has 3).

TEST PLAN
  Tested compilation of KDevPlatform, KDevelop, and KDev-Python (master branch for all).

REPOSITORY
  R33 KDevPlatform

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4274

AFFECTED FILES
  language/duchain/types/abstracttype.h
  language/duchain/types/containertypes.h
  language/duchain/types/unsuretype.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: nalvarez
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170125/7e1280dc/attachment-0001.html>


More information about the KDevelop-devel mailing list