[Differential] [Requested Changes To] D4221: Added VcsBasicEventModel

[Milian Wolff]

mwolff requested changes to this revision.
mwolff added a reviewer: mwolff.
mwolff added a comment.
This revision now requires changes to proceed.


  lgtm, just some documentation would be welcome from my side

INLINE COMMENTS

> vcseventmodel.cpp:154
> +{
> +    delete d;
> +}

QScopedPointer or unique_ptr

> vcseventmodel.h:37
>  
> -class KDEVPLATFORMVCS_EXPORT VcsEventModel : public QAbstractTableModel
> +class KDEVPLATFORMVCS_EXPORT VcsBasicEventModel : public QAbstractTableModel
>  {

could you please add some apidox that explains the difference? the names themselves are not enough for me

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D4221

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: skalinichev, #kdevelop, mwolff
Cc: mwolff, apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170122/ec8570ac/attachment.html>