[Differential] [Commented On] D4108: Partial Fix: display the plugins that failed to load

[Tomaz Canabrava]

tcanabrava added a comment.


  In https://phabricator.kde.org/D4108#78384, @mwolff wrote:
  
  > In https://phabricator.kde.org/D4108#78316, @tcanabrava wrote:
  >
  > > In https://phabricator.kde.org/D4108#78283, @mwolff wrote:
  > >
  > > > where do you update the error message when the user tries to enable a plugin from the setting dialog but it fails to load? you only construct the error display in the ctor, so this won't update properly, one will have to restart the dialog to show effect - please fix this
  > >
  > >
  > > I didnt found *where* the plugins are loaded after accepting the preferences, there's a method that will reload all the *global* plugins (git is not one of those, tougth), The preferences dialog only saves the preferences - if one plugin should be loaded or not, and the call to  Core::self()->pluginControllerInternal()->updateLoadedPlugins(); don't actually update the loaded plugins.
  >
  >
  > selector->load() applies this, no? Do you mean the list of plugins in the controller goes out-of-sync? If so, then we must fix this first (in a separate commit).
  
  
  Selector saves in the configuration what plugins should be loaded, but they don't reload after an initial failure, try this:
  Open KDvelop without git installed, you will have the "could not load git" error on the terminal, but the plugin will still be listed on the KPluginSelector (and the plugin object will be nullptr), then check the git plugin on the KPluginSelector and click ok. No message appears (on the terminal or on KDevelop).
  
  >> Besides that, I don't know *where* to put the messages that one plugin failed to load - IMO it should be inside of the KPluginSelector checkbox (click on the checkbox, plugin goes red saying that something is not right with it) but it don't have that option.
  > 
  > The way you added the message is fine for now. I simply want to have the message update itself after a plugin was (un)loaded and an error occurred.
  
  That's my point, the error only appear when we try to load the plugin in the start of kdevelop.

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D4108

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: tcanabrava, kfunk, apol, brauch, mwolff
Cc: mwolff, brauch, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170120/3abda821/attachment.html>