[Differential] [Updated] D4108: Partial Fix: display the plugins that failed to load

[Tomaz Canabrava]

tcanabrava marked 15 inline comments as done.
tcanabrava added a comment.


  In https://phabricator.kde.org/D4108#78283, @mwolff wrote:
  
  > where do you update the error message when the user tries to enable a plugin from the setting dialog but it fails to load? you only construct the error display in the ctor, so this won't update properly, one will have to restart the dialog to show effect - please fix this
  
  
  I didnt found *where* the plugins are loaded after accepting the preferences, there's a method that will reload all the *global* plugins (git is not one of those, tougth), The preferences dialog only saves the preferences - if one plugin should be loaded or not, and the call to  Core::self()->pluginControllerInternal()->updateLoadedPlugins(); don't actually update the loaded plugins.
  
  Besides that, I don't know *where* to put the messages that one plugin failed to load - IMO it should be inside of the KPluginSelector checkbox (click on the checkbox, plugin goes red saying that something is not right with it) but it don't have that option.
  
  Any tougths?

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D4108

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: tcanabrava, kfunk, apol, brauch, mwolff
Cc: mwolff, brauch, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170118/3356e798/attachment.html>