[Differential] [Commented On] D4108: Partial Fix: display the plugins that failed to load

[Sven Brauch]

brauch added a comment.


  Better than not displaying any info, I guess ;)

INLINE COMMENTS

> plugincontroller.cpp:571
> +        d->failedToLoad << qMakePair(info.name(), plugin->errorDescription());
> +        qDebug() << "Adding the" << info.name() << "into the failed to load";
>          unloadPlugin(pluginId);

qCDebug

> plugincontroller.h:141
> +    /* list of failed plugins with error messages */
> +    QList<QPair<QString, QString>> failedPlugins() const;
>  private:

QVector and put the QPair into a struct instead

> pluginpreferences.cpp:62
> +    PluginController* controller = qobject_cast<PluginController*>(Core::self()->pluginControllerInternal());
> +    QList<QPair<QString,QString>> failedPlugins = controller->failedPlugins();
> +    qDebug() << "Traying to get the failed to load stuff.";

auto

> pluginpreferences.cpp:63
> +    QList<QPair<QString,QString>> failedPlugins = controller->failedPlugins();
> +    qDebug() << "Traying to get the failed to load stuff.";
> +    if (failedPlugins.count()) {

qCDebug and proper wording please ;)

> pluginpreferences.cpp:65
> +    if (failedPlugins.count()) {
> +        qDebug() << "Passou por aqui";
> +        auto messageWidget = new KMessageWidget(this);

remove this

> pluginpreferences.cpp:70
> +        foreach(const auto& plugin, failedPlugins) {
> +            text += plugin.first + " " + plugin.second + "\n";
> +        }

should probably have a colon : in between or so, but then you need an i18n call as well

> pluginpreferences.cpp:70
> +        foreach(const auto& plugin, failedPlugins) {
> +            text += plugin.first + " " + plugin.second + "\n";
> +        }

also don't add a newline on the last item, the spacing is weird

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D4108

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: tcanabrava, kfunk, apol
Cc: brauch, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170117/bf5f5497/attachment-0001.html>