[Differential] [Updated] D4123: Show shortcuts on the tooltips.

[Kevin Funk]

kfunk added a comment.


  Note: This is something we could/should probably make more generic and use in other places as well.

INLINE COMMENTS

> mainwindow.cpp:354
> +        //First, try to remove the old shortcut from the current string.
> +        QString curr = action->toolTip();
> +        if (curr.indexOf('(') != -1) {

`curr` -> `toolTip`

> mainwindow.cpp:362
> +        } else if (!actionCollection()->defaultShortcut(action).isEmpty()) {
> +            action->setToolTip(curr + " (" + actionCollection()->defaultShortcut(action).toString() + ")");
> +        }

+1 on Anton's idea, maybe a different font format for the shortcut string would make sense.

/me proposes //italics//

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D4123

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: tcanabrava, apol, antonanikin, kfunk
Cc: antonanikin, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170116/0628fe45/attachment-0001.html>