Review Request 129829: refactor ContextMenuExtension::populateMenu to get rid of adding NULL Qaction warnings from QWidget::insertAction

René J.V. Bertin rjvbertin at
Sat Jan 14 13:00:41 UTC 2017

This is an automatically generated e-mail. To reply, visit:

Review request for KDevelop.

Repository: kdevplatform


When extensions like the debugger plugin(s) are not loaded attempts can be made to insert NULL QAction pointers into the context menu.
This patch modifies ContextMenuExtension::populateMenu() to avoid that.

Currently I filter out null pointers in a new `addContextActions` function, but maybe this should in fact be taken care of by `ContextMenuExtension::addAction()`?

Is it useful to print a warning or debug message about this kind of event, or is it in fact an accepted/able situation that is an expected outcome when plugins are not loaded?


  interfaces/contextmenuextension.cpp 8dc9a1135 



Works as intended.


René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list