[Differential] [Accepted] D4119: Show content types for tuples in tooltip

[Sven Brauch]

brauch accepted this revision.
brauch added a comment.
This revision is now accepted and ready to land.


  Nice change, except for what's marked. Thanks!

INLINE COMMENTS

> declarationnavigationcontext.cpp:60
> +    }
> +    return i18nc("refers to an unknown type in programming", "unknown");
> +}

sorry, you can't put this in 5.1 if you introduce a new string :/
reuse one?

> declarationnavigationcontext.cpp:86
> +                // Don't print more than five types explicitly
> +                typesArray << "...";
> +                break;

I think this needs to be translated

> declarationnavigationcontext.cpp:91
>          }
> -        else {
> -            contentType.append(i18nc("refers to an unknown type in programming", "unknown"));
> -        }
> -        modifyHtml() += i18nc("as in list of int, set of string", "%1 of %2", containerType, contentType);
> +        modifyHtml() += i18n("%1 of ( %2 )", containerType, typesArray.join(", "));
>      }

this needs a comment (i18nc)

> declarationnavigationcontext.h:47
> +private:
> +    QString typeLinkOrString(const AbstractType::Ptr type);
>  };

const&

REPOSITORY
  R53 KDevelop: Python Support

REVISION DETAIL
  https://phabricator.kde.org/D4119

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: flherne, brauch
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170113/dc618102/attachment-0001.html>