[Differential] [Request, 73 lines] D4119: Show content types for tuples in tooltip

Francis Herne noreply at phabricator.kde.org
Fri Jan 13 14:15:32 UTC 2017


flherne created this revision.
flherne added a reviewer: brauch.
flherne set the repository for this revision to R53 KDevelop: Python Support.
Restricted Application added a subscriber: kdevelop-devel.

REVISION SUMMARY
  (I'd quite like to put this in 5.1; the contents only being displayed in unsure-types is obviously a bug).
  
  `IndexedContainer::toString()` did this, but the tooltips use `DeclarationNavigationContext::htmlIdentifiedType()` which didn't.
  
  This led to the rather odd situation where unsure-types had *more* information:
  
    a = b = 1, 2
    b = "string"
    a  # 'tuple'
    b # 'unsure (tuple of ( int ), str)'
  
  There's still quite a lot of duplication in this function, and with the toString() methods, that should be addressed at some point.
  
  Incidentally, make the actual number of types used match the comment.

TEST PLAN
  Tried it on things, it worked...

REPOSITORY
  R53 KDevelop: Python Support

REVISION DETAIL
  https://phabricator.kde.org/D4119

AFFECTED FILES
  duchain/navigation/declarationnavigationcontext.cpp
  duchain/navigation/declarationnavigationcontext.h
  duchain/types/indexedcontainer.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: flherne, brauch
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170113/e306d14d/attachment.html>


More information about the KDevelop-devel mailing list